Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error for failed lookup #3932

Merged
merged 2 commits into from
Apr 19, 2018
Merged

Better error for failed lookup #3932

merged 2 commits into from
Apr 19, 2018

Conversation

chriseth
Copy link
Contributor

Fixes #2965

@chriseth chriseth requested a review from axic April 18, 2018 19:17
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also include the library specific test the original issue had.

@axic axic force-pushed the betterErrorForFailedLookup branch from 4e33ee5 to a94945d Compare April 18, 2018 21:57
function g() { L.f(1, 2, 3); }
}
// ----
// TypeError: (94-97): Member "f" not found or not visible after argument-dependent lookup in type(library L)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this test case from the original issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better question though: cannot we support overloads from libraries?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, it was too late.

@chriseth chriseth merged commit 6407f1f into develop Apr 19, 2018
@axic axic deleted the betterErrorForFailedLookup branch April 19, 2018 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants